Update deploy step of a job with building docs #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html |
antonwolfy
force-pushed
the
resolve_gh_1620
branch
from
d7c7c06 to
addad90
Compare
vlad-perevezentsev
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR closes #1620 issues.
The PR closes #1621 pull request as superseded.
A step
Deploy docsfrom building docs actions was indented to only build dpnp docs when the new commit is pushed to "master" branch. But due to wrong conditions the step was triggered from pull request of PR branch when event comes with action="closed" property.Another major issue is missing
keep_filesoption enabled for the step, which leads to removal of all files from "gh-pages" branch (as a pre-step), i.e. also including generated doc files relating to another PRs (located in a special "pull" folder and which has to be removed by separateCleanjob per each closing PR).The PR assumes to resolve both above issues.
Additionally GitHub bot user and email is used to push on "gh-pages" branch facelessly.